Details
-
Sub-task
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
3.4.0
-
Reviewed
Description
While reading the relevant yarn-federation-router's code, I found the following issues with log method in FederationClientInterceptor:
The log methods are inconsistent, some use the splicing method, and some use the placeholder method,as follows:
org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#getNewApplication
for (int i = 0; i < numSubmitRetries; ++i) { SubClusterId subClusterId = getRandomActiveSubCluster(subClustersActive); LOG.debug( "getNewApplication try #{} on SubCluster {}", i, subClusterId); ApplicationClientProtocol clientRMProxy = getClientRMProxyForSubCluster(subClusterId); ... }
org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#submitApplication
for (int i = 0; i < numSubmitRetries; ++i) { SubClusterId subClusterId = policyFacade.getHomeSubcluster( request.getApplicationSubmissionContext(), blacklist); LOG.info("submitApplication appId" + applicationId + " try #" + i + " on SubCluster " + subClusterId); ... }
I think the first way is better.
Attachments
Attachments
Issue Links
- links to