[YARN-11137] Improve log message in FederationClientInterceptor

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: federation
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Shilun Fan
• Reporter: Shilun Fan
• Created: 08/May/22 07:04
• Updated: 28/Jan/24 05:27
• Resolved: 25/May/22 00:21

Description

While reading the relevant yarn-federation-router's code, I found the following issues with log method in FederationClientInterceptor:

The log methods are inconsistent, some use the splicing method, and some use the placeholder method，as follows:

org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#getNewApplication

for (int i = 0; i < numSubmitRetries; ++i) {
      SubClusterId subClusterId = getRandomActiveSubCluster(subClustersActive);
      LOG.debug(
          "getNewApplication try #{} on SubCluster {}", i, subClusterId);
      ApplicationClientProtocol clientRMProxy =
          getClientRMProxyForSubCluster(subClusterId);
  ...
}

org.apache.hadoop.yarn.server.router.clientrmsubmit.FederationClientInterceptor#submitApplication

for (int i = 0; i < numSubmitRetries; ++i) {      
         SubClusterId subClusterId = policyFacade.getHomeSubcluster(
          request.getApplicationSubmissionContext(), blacklist);
      LOG.info("submitApplication appId" + applicationId + " try #" + i
          + " on SubCluster " + subClusterId);
   ...
} 

I think the first way is better.

Issue Links

• links to: GitHub Pull Request #4336