Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-11094

Follow up changes for YARN-10547

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.4.0
    • None
    • Reviewed

    Description

      As a follow up of YARN-10547, we need to fix the raw use of Map across the following classes:

      • AMDefinitionSLS
      • SLSRunner

      See this comment for details.

      The following methods are affected:

      • org.apache.hadoop.yarn.sls.AMDefinitionFactory#createFromSlsTrace
      • org.apache.hadoop.yarn.sls.AMDefinitionFactory#getAMContainerResourceSLS
      • org.apache.hadoop.yarn.sls.AMDefinitionSLS#getTaskContainers
      • Methods of TaskContainerDefinition.Builder
      • org.apache.hadoop.yarn.sls.AMDefinitionSLS.Builder#create
      • org.apache.hadoop.yarn.sls.SLSRunner#startAMFromSLSTrace

      Moreover, some generic cleanup in SLSRunner could be performed to eliminate:
      1. Redundant @SuppressWarnings("unchecked") annotations
      2. Explicit type arguments for some collections
      3. Remove exceptions from methods that never throwing them

      Attachments

        1. YARN-11094.002.patch
          18 kB
          Szilard Nemeth
        2. YARN-11094.001.patch
          82 kB
          Szilard Nemeth

        Issue Links

          Activity

            People

              snemeth Szilard Nemeth
              snemeth Szilard Nemeth
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: