Details
-
Improvement
-
Status: Resolved
-
Minor
-
Resolution: Fixed
-
None
-
None
-
Reviewed
Description
As a follow up of YARN-10547, we need to fix the raw use of Map across the following classes:
- AMDefinitionSLS
- SLSRunner
See this comment for details.
The following methods are affected:
- org.apache.hadoop.yarn.sls.AMDefinitionFactory#createFromSlsTrace
- org.apache.hadoop.yarn.sls.AMDefinitionFactory#getAMContainerResourceSLS
- org.apache.hadoop.yarn.sls.AMDefinitionSLS#getTaskContainers
- Methods of TaskContainerDefinition.Builder
- org.apache.hadoop.yarn.sls.AMDefinitionSLS.Builder#create
- org.apache.hadoop.yarn.sls.SLSRunner#startAMFromSLSTrace
Moreover, some generic cleanup in SLSRunner could be performed to eliminate:
1. Redundant @SuppressWarnings("unchecked") annotations
2. Explicit type arguments for some collections
3. Remove exceptions from methods that never throwing them
Attachments
Attachments
Issue Links
- relates to
-
YARN-10547 Decouple job parsing logic from SLSRunner
- Resolved