[YARN-10874] Refactor NM ContainerLaunch#getEnvDependencies's unit tests

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 3.4.0
• Component/s: yarn
• Labels: pull-request-available
• Hadoop Flags: Reviewed
• Assignee: Tamas Domok
• Reporter: Tamas Domok
• Created: 30/Jul/21 09:54
• Updated: 03/Aug/21 14:20
• Resolved: 03/Aug/21 14:20

Description

The YARN-10355 ticket states that the unit tests contains repeated code and the test methods are too long. We decided to split that ticket into two parts. The YARN-10355 will contain only the production code change (for the windows variant, the linux variant refactor is not feasible with regex, the original code is not the nicest, but it does it's thing).

 

Acceptance criteria:

• refactor the unit tests (e.g.: parameterised tests)
• extend the tests with extra checks

Issue Links

• relates to: YARN-10355 Refactor NM ContainerLaunch.java#orderEnvByDependencies
• links to: GitHub Pull Request #3248