[YARN-10355] Refactor NM ContainerLaunch.java#orderEnvByDependencies

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.4.0
• Fix Version/s: 3.4.0
• Component/s: yarn
• Labels: pull-request-available
• Target Version/s: 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Tamas Domok
• Reporter: Benjamin Teke
• Created: 20/Jul/20 15:52
• Updated: 26/Jan/24 05:52
• Resolved: 04/Aug/21 13:28

Description

The org.apache.hadoop.yarn.server.nodemanager.containermanager.launcher.ContainerLaunch#orderEnvByDependencies and it's helper method {{getEnvDependencies }}(together with the overrides) is hard to read. Some improvements could be made:

• use Pattern matching in the overrides of getEnvDependencies instead of iterating through the environmental variable strings char by char
• the unit tests contains a lot of repeated code and generally the test methods are long - they could be separated into different setup/helper and assertion methods

Issue Links

• is related to: YARN-10874 Refactor NM ContainerLaunch#getEnvDependencies's unit tests
• links to: GitHub Pull Request #3220