[YARN-10278] CapacityScheduler test framework ProportionalCapacityPreemptionPolicyMockFramework need some review

• Type: Task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.4.0, 3.3.1, 3.2.3
• Fix Version/s: 3.4.0, 3.3.1, 3.2.3
• Component/s: capacity scheduler, test
• Target Version/s: 3.4.0, 3.3.1, 3.2.3
• Hadoop Flags: Reviewed
• Assignee: Szilard Nemeth
• Reporter: Gergely Pollák
• Created: 19/May/20 10:28
• Updated: 12/Feb/24 07:31
• Resolved: 02/Dec/20 17:40

Description

This test framework class mocks a bit too heavily, and simulates CS internal behaviour with the mock methods over a point it is reasonably maintainable, any internal change in CS is a major headscratch.

A lot of tests depend on this class, so we should approach it carefully, but I think it's wroth to examine this class if it can be made a bit more resilient to changes, and easier to maintain. Or at least document it better.

Issue Links

• is depended upon by: YARN-10273 [Umbrella] Followup tasks for CapacityScheduler leaf queue changes (YARN-9879)