Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10278

CapacityScheduler test framework ProportionalCapacityPreemptionPolicyMockFramework need some review

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Task
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 3.4.0, 3.3.1, 3.2.3
    • 3.4.0, 3.3.1, 3.2.3
    • capacity scheduler, test
    • None

    Description

      This test framework class mocks a bit too heavily, and simulates CS internal behaviour with the mock methods over a point it is reasonably maintainable, any internal change in CS is a major headscratch.

      A lot of tests depend on this class, so we should approach it carefully, but I think it's wroth to examine this class if it can be made a bit more resilient to changes, and easier to maintain. Or at least document it better.

      Attachments

        1. YARN-10278.001.patch
          174 kB
          Szilard Nemeth
        2. YARN-10278.002.patch
          175 kB
          Szilard Nemeth
        3. YARN-10278.002.patch
          175 kB
          Szilard Nemeth
        4. YARN-10278.002.patch
          175 kB
          Szilard Nemeth
        5. YARN-10278.branch-3.1.001.patch
          135 kB
          Szilard Nemeth
        6. YARN-10278.branch-3.1.002.patch
          175 kB
          Szilard Nemeth
        7. YARN-10278.branch-3.1.003.patch
          174 kB
          Szilard Nemeth
        8. YARN-10278.branch-3.2.001.patch
          134 kB
          Szilard Nemeth
        9. YARN-10278.branch-3.2.002.patch
          174 kB
          Szilard Nemeth
        10. YARN-10278.branch-3.2.002.patch
          174 kB
          Szilard Nemeth
        11. YARN-10278.branch-3.3.001.patch
          175 kB
          Szilard Nemeth

        Issue Links

        is depended upon by

        Task - A task that needs to be done. YARN-10273 [Umbrella] Followup tasks for CapacityScheduler leaf queue changes (YARN-9879)

        • Major - Major loss of function.
        • Open

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            snemeth Szilard Nemeth Assign to me
            shuzirra Gergely Pollák
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment