[YARN-10189] Code cleanup in LeveldbRMStateStore

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.0, 3.2.2, 3.4.0
• Fix Version/s: 3.3.0, 3.2.2, 3.4.0
• Component/s: resourcemanager
• Target Version/s: 3.3.0, 3.2.2, 3.4.0
• Hadoop Flags: Reviewed
• Assignee: Benjamin Teke
• Reporter: Benjamin Teke
• Created: 09/Mar/20 15:28
• Updated: 11/Feb/24 06:18
• Resolved: 27/Apr/20 08:00

Description

Some things can be improved:

• throws Exception declaration can be removed from LeveldbRMStateStore.initInternal method 
• key variable is redundant in LeveldbRMStateStore.dbStoreVersion
• try can use automatic Resource management in LeveldbRMStateStore.loadReservationState/loadRMDTSecretManagerKeys/loadRMDTSecretManagerTokens/loadRMApps/... etc
• there were some methods which were copied to LeveldbConfigurationStore (ie: openDatabase, storeVersion, loadVersion, CompactionTimerClass nested class), a helper class could be created to reduce the duplicated code
• Any other cleanup

Issue Links

• is a clone of: YARN-9998 Code cleanup in LeveldbConfigurationStore