Uploaded image for project: 'Hadoop YARN'
  1. Hadoop YARN
  2. YARN-10189

Code cleanup in LeveldbRMStateStore

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • None
    • 3.3.0, 3.2.2, 3.4.0
    • None
    • None
    • Reviewed

    Description

      Some things can be improved:

      • throws Exception declaration can be removed from LeveldbRMStateStore.initInternal method 
      • key variable is redundant in LeveldbRMStateStore.dbStoreVersion
      • try can use automatic Resource management in LeveldbRMStateStore.loadReservationState/loadRMDTSecretManagerKeys/loadRMDTSecretManagerTokens/loadRMApps/... etc
      • there were some methods which were copied to LeveldbConfigurationStore (ie: openDatabase, storeVersion, loadVersion, CompactionTimerClass nested class), a helper class could be created to reduce the duplicated code
      • Any other cleanup

      Attachments

        1. YARN-10189.POC001.patch
          37 kB
          Benjamin Teke
        2. YARN-10189.POC002.patch
          38 kB
          Benjamin Teke
        3. YARN-10189.001.patch
          32 kB
          Benjamin Teke
        4. YARN-10189.branch-3.2.001.patch
          55 kB
          Benjamin Teke
        5. YARN-10189.branch-3.3.001.patch
          32 kB
          Benjamin Teke
        6. YARN-10189.branch-3.2.002.patch
          31 kB
          Benjamin Teke

        Issue Links

          Activity

            People

              bteke Benjamin Teke
              bteke Benjamin Teke
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: