Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      In the converter, this part is very strict and probably unnecessary:

          // Validate ordering policy
          if (queueConverter.isDrfPolicyUsedOnQueueLevel()) {
            if (queueConverter.isFifoOrFairSharePolicyUsed()) {
              throw new ConversionException(
                  "DRF ordering policy cannot be used together with fifo/fair");
            } else {
              capacitySchedulerConfig.set(
                  CapacitySchedulerConfiguration.RESOURCE_CALCULATOR_CLASS,
                  DominantResourceCalculator.class.getCanonicalName());
            }
          }
      

      It's also misleading, because Fair policy can be used under DRF, so the error message is incorrect.
      Let's remove these checks and rewrite the converter in a way that it generates a valid config even if fair/drf is somehow mixed.

        Attachments

        1. YARN-10085-001.patch
          21 kB
          Peter Bacsko
        2. YARN-10085-002.patch
          31 kB
          Peter Bacsko
        3. YARN-10085-003.patch
          31 kB
          Peter Bacsko
        4. YARN-10085-004.patch
          31 kB
          Peter Bacsko
        5. YARN-10085-004.patch
          31 kB
          Peter Bacsko
        6. YARN-10085-005.patch
          31 kB
          Peter Bacsko
        7. YARN-10085-006.patch
          40 kB
          Peter Bacsko

          Issue Links

            Activity

              People

              • Assignee:
                pbacsko Peter Bacsko
                Reporter:
                pbacsko Peter Bacsko
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: