[YARN-10085] FS-CS converter: remove mixed ordering policy check

• Type: Sub-task
• Status: Resolved
• Priority: Critical
• Resolution: Fixed
• Fix Version/s: 3.3.0
• Hadoop Flags: Reviewed
• Assignee: Peter Bacsko
• Reporter: Peter Bacsko
• Created: 15/Jan/20 12:18
• Updated: 28/Jan/20 14:42
• Resolved: 28/Jan/20 14:23

Description

In the converter, this part is very strict and probably unnecessary:

    // Validate ordering policy
    if (queueConverter.isDrfPolicyUsedOnQueueLevel()) {
      if (queueConverter.isFifoOrFairSharePolicyUsed()) {
        throw new ConversionException(
            "DRF ordering policy cannot be used together with fifo/fair");
      } else {
        capacitySchedulerConfig.set(
            CapacitySchedulerConfiguration.RESOURCE_CALCULATOR_CLASS,
            DominantResourceCalculator.class.getCanonicalName());
      }
    }

It's also misleading, because Fair policy can be used under DRF, so the error message is incorrect.
Let's remove these checks and rewrite the converter in a way that it generates a valid config even if fair/drf is somehow mixed.

Issue Links

• is related to: YARN-9892 Capacity Scheduler: Support DRF ordering policy on queue level