[WW-4536] potential memory leak with annotationActionValidatorManager

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.20
• Fix Version/s: 2.3.28, 2.5
• Component/s: XML Validators
• Assignee: Lukasz Lenart
• Reporter: adam brin
• Created: 16/Aug/15 20:44
• Updated: 27/Oct/22 10:57
• Resolved: 19/Oct/15 18:52

Description

We've recently been having issues with our app crashing and trying to track down the root causes. One of the things we've seen is that over the course of 1 day, 50% of our memory (almost 620 MB of 1.2 GB) is allocated to "com.opensymphony.xwork.validator.AnnotationActionValidatorManager" according to the heap dump. We also see millions of entries in two SynchronizedMap's:

• validatorCache (1,635,019 entries)
• validatorFileCache (87,321 entries)

Looking through the entries in the validator cache, we se entries for every unique page browsed within the app. Note: we're using staticParam mapping and NamedVariable PatternMatching in action names e.g. "${id}/${slug}" so effectively every url is unique.

Looking at the source code, should these maps perhaps be "WeakHashMaps" or WeakReferences so that they're disposed of?

(source code to the app is here: https://bitbucket.org/tdar/tdar.src/src )

Issue Links

• is duplicated by: WW-3715 Allow for dynamic validation xml files, by building validator cache based on action AND context
• is related to: WW-2996 Memory Leak when SlashesInActionNames is enabled and wildcards are used in actionnames
• is related to: WW-3753 The AnnotationActionValidatorManager does not adhere to the ActionValidatorManager interface's contract