[WW-3753] The AnnotationActionValidatorManager does not adhere to the ActionValidatorManager interface's contract

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.3.3
• Assignee: Lukasz Lenart
• Reporter: Rees Byars
• Created: 10/Feb/12 01:42
• Updated: 11/Oct/15 16:30
• Resolved: 26/Feb/12 09:28

Description

An ActionValidatorManager accepts a java.util.String "context" parameter for identifying the appropriate configurations. In the AnnotationActionValidatorManager's buildValidatorKey() method, however, "config.getName()" is used instead of the passed-in context. This violates the contract of the interface and tightly couples the AnnotationActionValidatorManager to the ValidationInterceptor.

I have a situation whereby I have created my own validation interceptor for a special case that passes in a context not derived from "proxy.getActionName()" (equivalent to config.getName() except for in the case of wildcards), only to find that this context isn't used properly by the manager. I then created my own manager, changing only the buildValidatorKey() to use the given context, and it works well.

Issue Links

• is related to: WW-2996 Memory Leak when SlashesInActionNames is enabled and wildcards are used in actionnames
• is related to: WW-3194 Can no longer have seperate xml validations for different action methods mapped with a wildcard
• relates to: WW-4536 potential memory leak with annotationActionValidatorManager