Uploaded image for project: 'Struts 2'
  1. Struts 2
  2. WW-4122

Wasted work in AnnotationParameterFilterIntereptor.intercept()

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.3.14.3
    • Fix Version/s: 2.3.16
    • Component/s: None
    • Labels:
    • Environment:

      any

    • Flags:
      Patch, Important

      Description

      The problem appears in version 2.3.14.3 and in revision 1495522. I
      attached a one-line patch that fixes it. This problem and the
      attached patch are similar to the previously fixed WW-4115 and its
      patch.

      In method "AnnotationParameterFilterIntereptor.intercept", the loop
      over "annotatedFields" should break immediately after "allowed" is set
      to "true". All the iterations after "allowed" is set to "true" do not
      perform any useful work, at best they just set "allowed" again to
      "true".

        Attachments

        1. patch.diff
          0.7 kB
          Adrian Nistor

          Activity

            People

            • Assignee:
              lukaszlenart Lukasz Lenart
              Reporter:
              adriannistor Adrian Nistor
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: