[WW-4120] Wasted work in ValidateVisitor.isExpression()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.14.3
• Fix Version/s: 2.3.16
• Component/s: Plugin - Embedded JSP
• Labels: patch performance

Environment

any

• Flags: Patch, Important
• Assignee: Lukasz Lenart
• Reporter: Adrian Nistor
• Created: 21/Jun/13 18:47
• Updated: 08/Dec/13 17:21
• Resolved: 12/Jul/13 07:19

Description

The problem appears in version 2.3.14.3 and in revision 1495522. I
attached a two-line patch that fixes it. This problem and the
attached patch are similar to the previously fixed WW-4115 and its
patch.

In method "ValidateVisitor.isExpression", the loop over "nodes" should
break immediately after "elExpression" is set to "true". All the
iterations after "elExpression" is set to "true" do not perform any
useful work, at best they just set "elExpression" again to "true".