[WW-4115] Wasted work in ValidateVisitor.getJspAttribute()

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.3.14.3
• Fix Version/s: 2.3.16
• Component/s: Plugin - Embedded JSP
• Labels: patch performance

Environment

any

• Flags: Patch
• Assignee: Lukasz Lenart
• Reporter: Adrian Nistor
• Created: 19/Jun/13 15:14
• Updated: 08/Dec/13 17:21
• Resolved: 20/Jun/13 06:51

Description

The problem appears in version 2.3.14.3 and in revision 1493157. I
attached a one-line patch that fixes it.

In method "ValidateVisitor.getJspAttribute", the loop over
"el.iterator()" should break immediately after "deferred" is set to
"true". All the iterations after "deferred" is set to "true" do not
perform any useful work, at best they just set "deferred" again to
"true".

Method "evaluateExtraParams" in class "ActionError" has a similar loop
(over "actionMessages"), and this loop breaks immediately after
"isEmptyList" is set to "false", just like in the proposed patch.
Other methods (e.g., "DebuggingInterceptor.printContext",
"FileUploadInterceptor.isNonEmpty", "CollectVisitor.checkSeen",
"JspDocumentParser.processChars") also have similar loops with similar
breaks, just like in the proposed patch.