[WICKET-4833] DateConverter is not thread-safe

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Invalid
• Affects Version/s: 1.4.19, 6.2.0
• Component/s: wicket
• Assignee: Unassigned
• Reporter: SoulSpirit
• Created: 24/Oct/12 09:43
• Updated: 25/Oct/12 14:07
• Resolved: 24/Oct/12 10:05

Description

As described in https://issues.apache.org/jira/browse/WICKET-102 , DateConverter internally uses DateFormat to do its job, without the external synchronization DateFormat's javadoc states it need.

Since DateConverter is used by Wicket in a multi-threaded scenario (converters instances can be shared between threads) it should guarantee thread-safeness.
A user of DateConverter (and he could be unaware of using a DateConverter) shouldn't worry about its internal mechanics, thus DateConverter should handle the synchronization by itself.

Tested on v1.4.19, and just browsed v6.2.0 sources to check if something changed.

Thanks in advance, and sorry for my sloppy english.

Issue Links

• is related to: WICKET-102 potential concurrency problem with DateConverter
• relates to: WICKET-4839 Date converters should use a new instance of DateFormat to be thread safe