[WICKET-102] potential concurrency problem with DateConverter

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 2.0 branch (discontinued), 1.3.0-beta1
• Fix Version/s: 2.0 branch (discontinued), 1.3.0-beta1
• Assignee: Unassigned
• Reporter: Eelco Hillenius
• Created: 23/Nov/06 01:44
• Updated: 24/Oct/12 09:46
• Resolved: 23/Nov/06 01:52

Description

DateConverter uses a 'cache' (HashMap) with DateFormats. The problem (don't ask me why I never noticed) is that SimpleDateFormats are not thread safe. Never were, never will be (see http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4264153 and http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4228335)

The solution is the remove setDateFormat (which is probably never used by anyone anyway), and always return new instances.

Issue Links

• relates to: WICKET-4833 DateConverter is not thread-safe