Wicket
  1. Wicket
  2. WICKET-4831

Append the feedback message CSS class instead of overriding it

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.8
    • Fix Version/s: 1.5.9, 6.3.0
    • Component/s: wicket
    • Labels:

      Description

      Hi,

      Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
      Both methods return #getCSSClass by default for backward compatibility.
      Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).

      The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.

      Best regards,
      Sebastien

        Issue Links

          Activity

          Hide
          Martin Grigorov added a comment -

          As decided in the linked discussion for 1.5.x/6.x series we will just append the feedback message class to the <li> and <span> elements.

          Show
          Martin Grigorov added a comment - As decided in the linked discussion for 1.5.x/6.x series we will just append the feedback message class to the <li> and <span> elements.
          Hide
          Sven Meier added a comment -

          You'll have to remove class="errorlevel" from Feedback's markup.

          Show
          Sven Meier added a comment - You'll have to remove class="errorlevel" from Feedback's markup.
          Hide
          Sebastien Briquet added a comment -

          Hi Martin,

          I am doing some cleaning (closing) in revolved tickets I have opened.
          May I close this one? (I don't know because there is an opened sub-task...)

          Thanks in advance,
          Sebastien.

          Show
          Sebastien Briquet added a comment - Hi Martin, I am doing some cleaning (closing) in revolved tickets I have opened. May I close this one? (I don't know because there is an opened sub-task...) Thanks in advance, Sebastien.
          Hide
          Martin Grigorov added a comment -

          Hi Sebastien,

          Yes, please close it.
          The sub-task will be handled for Wicket 7.

          Show
          Martin Grigorov added a comment - Hi Sebastien, Yes, please close it. The sub-task will be handled for Wicket 7.

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Sebastien Briquet
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development