[WICKET-4831] Append the feedback message CSS class instead of overriding it

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.8
• Fix Version/s: 1.5.9, 6.3.0
• Component/s: wicket
• Labels: patch
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Sebastien Briquet
• Created: 22/Oct/12 18:39
• Updated: 04/Mar/13 08:57
• Resolved: 02/Nov/12 17:03

Description

Hi,

Following the users@ thread entitled "Custom CSS for Feedback message is broken in 1.5", please find attached a patch that provides #getListCSSClass (applied onto <li /> elements) and #getLabelCSSClass (applied onto the underneath <span /> element).
Both methods return #getCSSClass by default for backward compatibility.
Please note that #getCSSClass has been marked as deprecated (and to be changed to private in next version) to prevent confusion. (imagine the user overrides all 3 methods for instance, its #getCSSClass will be ineffective).

The patch has been done based on wicket-1.5.x branch (github). I did not see a relevant dev branch for 1.5.9 specifically.

Best regards,
Sebastien

Issue Links

• links to: Mail discussion with a vote

Sub-Tasks

• Do not set CSS class on the li > span element for a feedback message: Resolved