Wicket
  1. Wicket
  2. WICKET-4803

UrlDecoder should log a message when invalid input is provided

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.8, 6.5.0
    • Fix Version/s: 1.5.10, 6.7.0, 1.4.22
    • Component/s: wicket
    • Labels:
      None

      Description

      In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException, otherwise they are caught by the exception handler form the servlet container (jetty, tomcat, ...) which then uses their http 500 error code configuration instead of the exception handling of wicket.

      Wrapping them would be good for consistency and help manage runtime exceptions.
      These are the two exceptions:
      throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern");
      throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage());

        Issue Links

          Activity

          Martin Grigorov made changes -
          Remote Link This issue links to "Discussion about changing the behavior in Tomcat (Web Link)" [ 12059 ]
          Martin Grigorov made changes -
          Fix Version/s 1.4.22 [ 12324070 ]
          Martin Grigorov made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Fix Version/s 6.7.0 [ 12323964 ]
          Resolution Fixed [ 1 ]
          Martin Grigorov made changes -
          Summary Unwrapped IllegalArgumentException in WicketURLDecoder UrlDecoder should log a message when invalid input is provided
          Martin Grigorov made changes -
          Affects Version/s 6.5.0 [ 12323540 ]
          Martin Funk made changes -
          Comment [ Hi,

          no quickstart needed. Just do it live http://www.wicket-library.com/wicket-examples/index.html?%%% ]
          Martin Grigorov made changes -
          Assignee Martin Grigorov [ mgrigorov ]
          Martin Grigorov made changes -
          Fix Version/s 1.5.10 [ 12323510 ]
          Johan Heylen made changes -
          Link This issue duplicates WICKET-4493 [ WICKET-4493 ]
          Johan Heylen made changes -
          Field Original Value New Value
          Attachment WICKET-4803-quickstart-testcase-and-example.zip [ 12547779 ]
          Johan Heylen created issue -

            People

            • Assignee:
              Martin Grigorov
              Reporter:
              Johan Heylen
            • Votes:
              2 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development