Uploaded image for project: 'Wicket'
  1. Wicket
  2. WICKET-4803

UrlDecoder should log a message when invalid input is provided

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.5.8, 6.5.0
    • Fix Version/s: 1.5.10, 6.7.0, 1.4.22
    • Component/s: wicket
    • Labels:
      None

      Description

      In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException, otherwise they are caught by the exception handler form the servlet container (jetty, tomcat, ...) which then uses their http 500 error code configuration instead of the exception handling of wicket.

      Wrapping them would be good for consistency and help manage runtime exceptions.
      These are the two exceptions:
      throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern");
      throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage());

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mgrigorov Martin Grigorov
                Reporter:
                johanh@dns.be Johan Heylen
              • Votes:
                2 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: