[WICKET-4803] UrlDecoder should log a message when invalid input is provided

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 1.5.8, 6.5.0
• Fix Version/s: 1.5.10, 6.7.0, 1.4.22
• Component/s: wicket
• Assignee: Martin Tzvetanov Grigorov
• Reporter: Johan Heylen
• Created: 04/Oct/12 16:35
• Updated: 04/Mar/13 08:32
• Resolved: 20/Feb/13 08:14

Description

In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException, otherwise they are caught by the exception handler form the servlet container (jetty, tomcat, ...) which then uses their http 500 error code configuration instead of the exception handling of wicket.

Wrapping them would be good for consistency and help manage runtime exceptions.
These are the two exceptions:
throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern");
throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage());

Issue Links

• duplicates: WICKET-4493 Unwrapped IllegalArgumentException in WicketURLDecoder
• links to: Discussion about changing the behavior in Tomcat