[WICKET-4493] Unwrapped IllegalArgumentException in WicketURLDecoder

• Type: Task
• Status: Resolved
• Priority: Minor
• Resolution: Won't Fix
• Affects Version/s: 1.4.19
• Component/s: wicket
• Assignee: Unassigned
• Reporter: James McIntosh
• Created: 12/Apr/12 00:46
• Updated: 05/Oct/12 07:26
• Resolved: 12/Apr/12 06:19

Description

In the class: org.apache.wicket.protocol.http.WicketURLDecoder there are two IllegalArgumentException which should be wrapped in WicketRuntimeException

Wrapping them would be good for consistency and help manage runtime exceptions.

These are the two exceptions, lines 164 and 179:

throw new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern");
throw new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage());

e.g.

throw new WicketRuntimeException(new IllegalArgumentException("URLDecoder: Incomplete trailing escape (%) pattern"));
throw new WicketRuntimeException(new IllegalArgumentException("URLDecoder: Illegal hex characters in escape (%) pattern - " + e.getMessage()));

Other similar runtime exceptions found:

org.apache.wicket.protocol.http.servlet.MultipartServletWebRequest

Lines 106, 114
throw new IllegalArgumentException("argument maxSize must be not null");
throw new IllegalStateException("ServletRequest does not contain multipart content. One possible solution is to explicitly call Form.setMultipart(true), Wicket tries its best to auto-detect multipart forms but there are certain situation where it cannot.");

Issue Links

• is duplicated by: WICKET-4803 UrlDecoder should log a message when invalid input is provided