Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.8.0
    • Fix Version/s: 0.8.0
    • Component/s: core
    • Labels:
      None

      Description

      In all private clouds, the user needs to supply the cloud endpoint url to connect to. Currently, Whirr has no means to supply this, outside diverting to jclouds-specific property "jclouds.endpoint" or "providername.endpoint"

      The impact is that the CLI and other tools neither document, nor make easy supplying this. For example, a user should intuitively be able to supply --endpoint http://keystonehost/v2.0/ for openstack, but right now, it is essentially a secret!

      1. WHIRR-630.patch
        14 kB
        Adrian Cole
      2. WHIRR-630.patch
        16 kB
        Adrian Cole

        Issue Links

          Activity

          Hide
          Adrian Cole added a comment -

          adds whirr.endpoint and whirr.blobstore-endpoint, corresponding to --endpoint and --blobstore-endpoint

          Show
          Adrian Cole added a comment - adds whirr.endpoint and whirr.blobstore-endpoint, corresponding to --endpoint and --blobstore-endpoint
          Hide
          Tom White added a comment -

          Looks good. The only thing I noticed was the use of Optional<String> in ClusterSpec, which is inconsistent with other optional values. Also, getBlobStoreEndpoint() returns a Optional<String> and setEndpoint() takes a String, which is not the normal beans pattern. How about having getBlobStoreEndpoint() return a String and getOptionalBlobStoreEndpoint() return a Optional<String>? This would allow us to add optional getters for the other optional values in a compatible way at a later point.

          Show
          Tom White added a comment - Looks good. The only thing I noticed was the use of Optional<String> in ClusterSpec, which is inconsistent with other optional values. Also, getBlobStoreEndpoint() returns a Optional<String> and setEndpoint() takes a String, which is not the normal beans pattern. How about having getBlobStoreEndpoint() return a String and getOptionalBlobStoreEndpoint() return a Optional<String>? This would allow us to add optional getters for the other optional values in a compatible way at a later point.
          Hide
          Adrian Cole added a comment -

          thanks for the review.

          In the interest of time, I'll just undo optional in general, as there's a huge opportunity for mutation cleanup and very little value doing this only in this patch.

          Show
          Adrian Cole added a comment - thanks for the review. In the interest of time, I'll just undo optional in general, as there's a huge opportunity for mutation cleanup and very little value doing this only in this patch.
          Hide
          Adrian Cole added a comment -

          new patch w/o optionals

          Show
          Adrian Cole added a comment - new patch w/o optionals
          Hide
          Tom White added a comment -

          The credential field is now missing from the Key objects - is that intended?

          Show
          Tom White added a comment - The credential field is now missing from the Key objects - is that intended?
          Hide
          Tom White added a comment -

          Adrian says it is, since it shouldn't be a part of the key.

          +1

          Show
          Tom White added a comment - Adrian says it is, since it shouldn't be a part of the key. +1
          Hide
          Adrian Cole added a comment -

          Committed revision 1374365.

          Show
          Adrian Cole added a comment - Committed revision 1374365.

            People

            • Assignee:
              Adrian Cole
              Reporter:
              Adrian Cole
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 4h
                4h
                Remaining:
                Remaining Estimate - 4h
                4h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development