[WAGON-498] ScmWagon should work in binary and shallow mode when possible

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0, 3.1.0
• Fix Version/s: 3.1.0
• Component/s: wagon-scm
• Assignee: Michael Osipov
• Reporter: Ilya Basin
• Created: 18/Feb/18 19:47
• Updated: 04/Jun/18 11:05
• Resolved: 04/Jun/18 11:05

Description

See SCM-867

By default, CVSNT will corrupt jars during `mvn deploy`. Vanilla CVS less likely, but still possible due to Keyword substitution. ScmWagon needs to perform checkout and add commands with the '-kb' flag (binary).

For that we need to call the overloaded methods added recently in maven-scm 1.9.6.

UPD: As it turns out, svn may also change files, if enable-auto-props is on. The test case "testWagon" which could reveal that is disabled by mistake: it runs only if supportsGetIfNewer(), but we don't call getIfNewer() there.

To demonstrate the issue, edit your subversion config file:

[miscellany]
enable-auto-props = yes
[auto-props]
test-resource = svn:eol-style=CRLF

This will not affect checkin, because the test file already has LF, but the auto property will be set and next time the file will be checked out with CRLF and #testWagon will fail.

UPD2: for git should also set the shallow flag

Issue Links

• blocks: WAGON-495 Fix checkoutDirectory leak
• blocks: WAGON-500 Re-enable ScmCvsExeWagonTest
• blocks: WAGON-501 Add ScmGitExeWagonTest
• is blocked by: SCM-867 ScmWagon has no way to work with CVS and SVN in binary mode
• is blocked by: SCM-881 ScmWagon has no way to work with SVN in binary mode
• is blocked by: SCM-882 ScmWagon has no way to work with GIT in binary mode
• links to: GitHub Pull Request #42
• links to: GitHub Pull Request #42