[WAGON-495] Fix checkoutDirectory leak

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0, 3.1.0
• Fix Version/s: 3.1.0
• Component/s: wagon-scm
• Assignee: Michael Osipov
• Reporter: Ilya Basin
• Created: 08/Feb/18 17:01
• Updated: 04/Jun/18 11:03
• Resolved: 04/Jun/18 11:03

Description

During deploy artifacts to SVN an instance of ScmWagon is initialized and artifact metadata is downloaded to a local folder. After that maven tries to upload the jar file. ScmWagon.put(File,String) is called which internally overwrites the checkoutDirectory field and checks out the repo again to another temporary folder. The original folder is forgotten.

Maven uploads jars, poms, checksums and for each file ScmWagon checks out a new directory.

In the end the closeConnection() method is called which removes the last used folder.

UPD: this causes false positive in testWagonPutDirectoryWhenDirectoryAlreadyExists(): the test deletes the test checkout dir before calling get(), but the wagon checkout dir remains and the file is retrieved from there.

Issue Links

• blocks: WAGON-503 Directory gives out of date error in putDirectory() to a non-empty Subversion repo
• blocks: WAGON-501 Add ScmGitExeWagonTest
• is blocked by: WAGON-497 ScmWagon#put() strips parent dirs from the target path if they already exist in SCM
• is blocked by: WAGON-498 ScmWagon should work in binary and shallow mode when possible
• links to: GitHub Pull Request #46
• links to: GitHub Pull Request #46