Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-480

Non-threadsafe HttpClientContext is shared between threaded use of HttpClientWagon

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.11
    • Fix Version/s: 2.12
    • Component/s: wagon-http
    • Labels:
      None

      Description

      The HttpClientContext is used as an instance private object, populated only once during connect(). The Wagon instance can be shared between multiple threads causing any kind of side effects to the requests like failing auth or abnormal redirects.

      With the Jetty 8 upgrade of all tests several unit tests failed to authenticate.

      This issue has been found during WAGON-474.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-wagon #1330 (See https://builds.apache.org/job/maven-wagon/1330/)
          WAGON-480 Non-threadsafe HttpClientContext is shared between threaded (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=1a005f1c3fe7492c10b06567738453118f1c15b6)

          • (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-wagon #1330 (See https://builds.apache.org/job/maven-wagon/1330/ ) WAGON-480 Non-threadsafe HttpClientContext is shared between threaded (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=1a005f1c3fe7492c10b06567738453118f1c15b6 ) (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with 1a005f1c3fe7492c10b06567738453118f1c15b6 .

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development