Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-479

Preemptive auth with HTTP Provider may fail because BasicScheme is added as completed=true to the AuthCache

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.11
    • Fix Version/s: 2.12
    • Component/s: wagon-http
    • Labels:
      None
    • Flags:
      Important

      Description

      Currently, to prepopulate preemptive authentication for target and proxy, BasicScheme is created and processChallenge() is called. Then it is added to the AuthCache. This causes two issues:

      1. The reference documentation never shows to do so.
      2. With the Jetty 8 upgrade of all tests several unit tests failed because the scheme was set to completed=true initially and never reacted on requested preemptive auth or simply obstained from responding to 401 with proper credentials altogether.

      This issue has been found during WAGON-474.

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build maven-wagon #1330 (See https://builds.apache.org/job/maven-wagon/1330/)
          WAGON-479 Preemptive auth with HTTP Provider may fail because (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=4074598777fad44a3c34c71c5842b71a03e1da3f)

          • (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build maven-wagon #1330 (See https://builds.apache.org/job/maven-wagon/1330/ ) WAGON-479 Preemptive auth with HTTP Provider may fail because (michaelo: http://git-wip-us.apache.org/repos/asf/?p=maven-wagon.git&a=commit&h=4074598777fad44a3c34c71c5842b71a03e1da3f ) (edit) wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/AbstractHttpClientWagon.java
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with 4074598777fad44a3c34c71c5842b71a03e1da3f .

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development