Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-447

Remove Commons Lang 2 for a few cases

        Details

        • Type: Task
        • Status: Closed
        • Priority: Major
        • Resolution: Fixed
        • Affects Version/s: 2.11
        • Fix Version/s: 2.12
        • Component/s: None
        • Labels:
          None

          Description

          There are only a few cases where Commons Lang is used. We can do without and avoid the dependency.

            Issue Links

            is duplicated by

            Bug - A problem which impairs or prevents the functions of the product. WAGON-448 Use Java String replace to avoid commons-lang dependency

            • Major - Major loss of function.
            • Closed

              Activity

              Ascending order - Click to sort in descending order
              Hide
              Permalink
              michael-o Michael Osipov added a comment -

              Plexus Utils are used throughout but from Commons Lang only StringUtils are used. Plexus Utils offers the same operations. We can replace and remove that dependency.

              Show
              michael-o Michael Osipov added a comment - Plexus Utils are used throughout but from Commons Lang only StringUtils are used. Plexus Utils offers the same operations. We can replace and remove that dependency.
              Hide
              Permalink
              michael-o Michael Osipov added a comment -

              Pushed to branch WAGON-447 until tests can be run successfully.

              Show
              michael-o Michael Osipov added a comment - Pushed to branch WAGON-447 until tests can be run successfully.
              Hide
              Permalink
              fabianlange Fabian Lange added a comment -

              Hi Michael,
              would you mind including my change from 448 into your change? In wagon-file you do not need any utility library at all, but can directly use the JDK functionality.

              Show
              fabianlange Fabian Lange added a comment - Hi Michael, would you mind including my change from 448 into your change? In wagon-file you do not need any utility library at all, but can directly use the JDK functionality.
              Hide
              Permalink
              fabianlange Fabian Lange added a comment -

              PS: What is the likelyhood we did a similar motivated change after such a long lifetime of the project within 1 day. I checked the jira before you opened 447...

              Show
              fabianlange Fabian Lange added a comment - PS: What is the likelyhood we did a similar motivated change after such a long lifetime of the project within 1 day. I checked the jira before you opened 447...
              Hide
              Permalink
              michael-o Michael Osipov added a comment - - edited

              Yes, I will. I have closed WAGON-448 because Plexus Utils is used throughout and you can't avoid that dependency anyway. There is no need to have two deps doing the same thing.

              Show
              michael-o Michael Osipov added a comment - - edited Yes, I will. I have closed WAGON-448 because Plexus Utils is used throughout and you can't avoid that dependency anyway. There is no need to have two deps doing the same thing.
              Hide
              Permalink
              michael-o Michael Osipov added a comment -

              This is coincidence. The is no maintenance window where someone checks the open isuses.

              Show
              michael-o Michael Osipov added a comment - This is coincidence. The is no maintenance window where someone checks the open isuses.
              Hide
              Permalink
              michael-o Michael Osipov added a comment -

              Fixed with f341bf76f368b8a088b048eef727a48d75dbad20.

              Show
              michael-o Michael Osipov added a comment - Fixed with f341bf76f368b8a088b048eef727a48d75dbad20 .
              Hide
              Permalink
              hudson Hudson added a comment -

              SUCCESS: Integrated in maven-wagon #1307 (See https://builds.apache.org/job/maven-wagon/1307/)
              WAGON-447 Remove Commons Lang 2 for a few cases (michaelo: rev f341bf76f368b8a088b048eef727a48d75dbad20)

              • wagon-providers/wagon-http-shared/pom.xml
              • wagon-providers/wagon-webdav-jackrabbit/pom.xml
              • wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java
              • wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java
              • wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java
              • pom.xml
              • wagon-providers/wagon-http/pom.xml
              • wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java
              • wagon-providers/wagon-file/pom.xml
              Show
              hudson Hudson added a comment - SUCCESS: Integrated in maven-wagon #1307 (See https://builds.apache.org/job/maven-wagon/1307/ ) WAGON-447 Remove Commons Lang 2 for a few cases (michaelo: rev f341bf76f368b8a088b048eef727a48d75dbad20) wagon-providers/wagon-http-shared/pom.xml wagon-providers/wagon-webdav-jackrabbit/pom.xml wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java pom.xml wagon-providers/wagon-http/pom.xml wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java wagon-providers/wagon-file/pom.xml

                People

                • Assignee:
                  michael-o Michael Osipov
                  Reporter:
                  michael-o Michael Osipov
                • Votes:
                  0 Vote for this issue
                  Watchers:
                  3 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:

                    Development