Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.11
    • Fix Version/s: 2.12
    • Component/s: None
    • Labels:
      None

      Description

      There are only a few cases where Commons Lang is used. We can do without and avoid the dependency.

        Issue Links

          Activity

          Hide
          michael-o Michael Osipov added a comment -

          Plexus Utils are used throughout but from Commons Lang only StringUtils are used. Plexus Utils offers the same operations. We can replace and remove that dependency.

          Show
          michael-o Michael Osipov added a comment - Plexus Utils are used throughout but from Commons Lang only StringUtils are used. Plexus Utils offers the same operations. We can replace and remove that dependency.
          Hide
          michael-o Michael Osipov added a comment -

          Pushed to branch WAGON-447 until tests can be run successfully.

          Show
          michael-o Michael Osipov added a comment - Pushed to branch WAGON-447 until tests can be run successfully.
          Hide
          fabianlange Fabian Lange added a comment -

          Hi Michael,
          would you mind including my change from 448 into your change? In wagon-file you do not need any utility library at all, but can directly use the JDK functionality.

          Show
          fabianlange Fabian Lange added a comment - Hi Michael, would you mind including my change from 448 into your change? In wagon-file you do not need any utility library at all, but can directly use the JDK functionality.
          Hide
          fabianlange Fabian Lange added a comment -

          PS: What is the likelyhood we did a similar motivated change after such a long lifetime of the project within 1 day. I checked the jira before you opened 447...

          Show
          fabianlange Fabian Lange added a comment - PS: What is the likelyhood we did a similar motivated change after such a long lifetime of the project within 1 day. I checked the jira before you opened 447...
          Hide
          michael-o Michael Osipov added a comment - - edited

          Yes, I will. I have closed WAGON-448 because Plexus Utils is used throughout and you can't avoid that dependency anyway. There is no need to have two deps doing the same thing.

          Show
          michael-o Michael Osipov added a comment - - edited Yes, I will. I have closed WAGON-448 because Plexus Utils is used throughout and you can't avoid that dependency anyway. There is no need to have two deps doing the same thing.
          Hide
          michael-o Michael Osipov added a comment -

          This is coincidence. The is no maintenance window where someone checks the open isuses.

          Show
          michael-o Michael Osipov added a comment - This is coincidence. The is no maintenance window where someone checks the open isuses.
          Hide
          michael-o Michael Osipov added a comment -
          Show
          michael-o Michael Osipov added a comment - Fixed with f341bf76f368b8a088b048eef727a48d75dbad20 .
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in maven-wagon #1307 (See https://builds.apache.org/job/maven-wagon/1307/)
          WAGON-447 Remove Commons Lang 2 for a few cases (michaelo: rev f341bf76f368b8a088b048eef727a48d75dbad20)

          • wagon-providers/wagon-http-shared/pom.xml
          • wagon-providers/wagon-webdav-jackrabbit/pom.xml
          • wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java
          • wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java
          • wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java
          • pom.xml
          • wagon-providers/wagon-http/pom.xml
          • wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java
          • wagon-providers/wagon-file/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in maven-wagon #1307 (See https://builds.apache.org/job/maven-wagon/1307/ ) WAGON-447 Remove Commons Lang 2 for a few cases (michaelo: rev f341bf76f368b8a088b048eef727a48d75dbad20) wagon-providers/wagon-http-shared/pom.xml wagon-providers/wagon-webdav-jackrabbit/pom.xml wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java wagon-providers/wagon-webdav-jackrabbit/src/main/java/org/apache/maven/wagon/providers/webdav/AbstractHttpClientWagon.java wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/HtmlFileListParser.java pom.xml wagon-providers/wagon-http/pom.xml wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/EncodingUtil.java wagon-providers/wagon-file/pom.xml

            People

            • Assignee:
              michael-o Michael Osipov
              Reporter:
              michael-o Michael Osipov
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development