Uploaded image for project: 'Maven Wagon'
  1. Maven Wagon
  2. WAGON-448

Use Java String replace to avoid commons-lang dependency

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Duplicate
    • None
    • None
    • wagon-file
    • None

    Description

      I am trying to reduce the amount of dependencies of the Apache Karaf project.
      One of the subcomponents uses wagon-http and wagon-file. By doing so, it receives a dependency to commons-lang.

      The reason is that wagon-file has a single use of StringUtils.replaceAll().

      https://github.com/apache/maven-wagon/blob/master/wagon-providers/wagon-file/src/main/java/org/apache/maven/wagon/providers/file/FileWagon.java#L206

      This dependency can be easily avoided using the JDK util

      destinationPath.replace('\\', '/');
      

      while this is also a bit faster, the main benefit is that we now can completely remove the lang dependency.

      Thank you!

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              fabianlange Fabian Lange
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: