Details
-
New Feature
-
Status: Resolved
-
Major
-
Resolution: Fixed
-
None
-
None
Description
There are a few tweaks which are necessary for Windows 10 images to work correctly.
The database schema should be updated. However, it would be much better if VCL-566 were completed before supporting Windows 10.
The product version number is something like 10.0.10240. For Windows 7 and 8.x images, the version number began with 6.. There are some places in the code which detect if the version is 5.x or 6.x, but nothing else. These need to be updated. One example is in cygwin-sshd-config.sh:
if [[ $WINDOWS_VERSION =~ ^6\. ]]; then echo Configuring sshd firewall port 22 exception for Windows 6.x netsh.exe advfirewall firewall delete rule name=all dir=in protocol=TCP localport=22 netsh.exe advfirewall firewall add rule name="VCL: allow SSH port 22 from any address" description="Allows incoming SSH (TCP port 22) traffic from any address" protocol=TCP localport=22 action=allow enable=yes dir=in localip=any remoteip=any else echo Configuring sshd firewall port 22 exception for Windows 5.x netsh.exe firewall set portopening name = "Cygwin SSHD" protocol = TCP port = 22 mode = ENABLE profile = ALL scope = ALL fi
This section checks if the OS is version 6.x, and defaults to the 5.x firewall commands. As a result, it attempts to run the 5.x commands on 10.x.