Uploaded image for project: 'Apache Twill'
  1. Apache Twill
  2. TWILL-187

Max app start time should be configurable.

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.10.0
    • Component/s: None
    • Labels:
      None

      Description

      The YarnTwillController waits at most 60 seconds (Constants.APPLICATION_MAX_START_SECONDS) for the app master to start up before killing the app. This number should be configurable instead of hardcoded. For example, it is a fairly common use case to schedule programs to run at regular intervals in a cluster. If a bunch of programs are started at the same time, this time out can be easily reached.

      On a small development cluster, I've reached this timeout if there are 30-40 concurrent program starts.

        Issue Links

          Activity

          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user chtyim opened a pull request:

          https://github.com/apache/twill/pull/22

          (TWILL-187) Added max start time

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/chtyim/twill feature/twill-187

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/twill/pull/22.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #22


          commit 5a2227303cfcf039d714f5b8917d06325066d17d
          Author: Terence Yim <chtyim@apache.org>
          Date: 2017-01-07T01:56:53Z

          (TWILL-187) Added max start time


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user chtyim opened a pull request: https://github.com/apache/twill/pull/22 ( TWILL-187 ) Added max start time You can merge this pull request into a Git repository by running: $ git pull https://github.com/chtyim/twill feature/twill-187 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/twill/pull/22.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #22 commit 5a2227303cfcf039d714f5b8917d06325066d17d Author: Terence Yim <chtyim@apache.org> Date: 2017-01-07T01:56:53Z ( TWILL-187 ) Added max start time
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user gokulavasan commented on a diff in the pull request:

          https://github.com/apache/twill/pull/22#discussion_r95049555

          — Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java —
          @@ -257,8 +258,19 @@
          TwillPreparer setLogLevels(String runnableName, Map<String, LogEntry.Level> logLevelsForRunnable);

          /**

          • * Starts the application.
            + * Starts the application. It's the same as calling {@link #start(long, TimeUnit)}

            with timeout of 60 seconds.

              • End diff –

          Is there any constant that we can refer to for '60' ?

          Show
          githubbot ASF GitHub Bot added a comment - Github user gokulavasan commented on a diff in the pull request: https://github.com/apache/twill/pull/22#discussion_r95049555 — Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java — @@ -257,8 +258,19 @@ TwillPreparer setLogLevels(String runnableName, Map<String, LogEntry.Level> logLevelsForRunnable); /** * Starts the application. + * Starts the application. It's the same as calling {@link #start(long, TimeUnit)} with timeout of 60 seconds. End diff – Is there any constant that we can refer to for '60' ?
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chtyim commented on the issue:

          https://github.com/apache/twill/pull/22

          For the stop timeout, it is cover by TWILL-192, as the changes are more complicate in the stop case

          Show
          githubbot ASF GitHub Bot added a comment - Github user chtyim commented on the issue: https://github.com/apache/twill/pull/22 For the stop timeout, it is cover by TWILL-192 , as the changes are more complicate in the stop case
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user chtyim commented on a diff in the pull request:

          https://github.com/apache/twill/pull/22#discussion_r95050430

          — Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java —
          @@ -257,8 +258,19 @@
          TwillPreparer setLogLevels(String runnableName, Map<String, LogEntry.Level> logLevelsForRunnable);

          /**

          • * Starts the application.
            + * Starts the application. It's the same as calling {@link #start(long, TimeUnit)}

            with timeout of 60 seconds.

              • End diff –

          There is, however it's defined in the core module, hence can't refer to it in the API module

          Show
          githubbot ASF GitHub Bot added a comment - Github user chtyim commented on a diff in the pull request: https://github.com/apache/twill/pull/22#discussion_r95050430 — Diff: twill-api/src/main/java/org/apache/twill/api/TwillPreparer.java — @@ -257,8 +258,19 @@ TwillPreparer setLogLevels(String runnableName, Map<String, LogEntry.Level> logLevelsForRunnable); /** * Starts the application. + * Starts the application. It's the same as calling {@link #start(long, TimeUnit)} with timeout of 60 seconds. End diff – There is, however it's defined in the core module, hence can't refer to it in the API module
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/twill/pull/22

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/twill/pull/22

            People

            • Assignee:
              chtyim Terence Yim
              Reporter:
              ashau Albert Shau
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development