[TS-3935] Compile errors (warnings) with modern clang

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.1.0
• Component/s: Management API
• Assignee: Alan M. Carroll
• Reporter: Leif Hedstrom
• Created: 22/Sep/15 20:37
• Updated: 04/Feb/16 18:48
• Resolved: 17/Dec/15 02:24

Description

  CXX      CoreAPI.lo
../../../../mgmt/api/CoreAPI.cc:370:188: error: use of logical '||' with constant operand [-Werror,-Wconstant-logical-operand]
  if ((threads).n) for (pid_t *qq__threadid = (pid_t *)0, threadid = (threads).v[0]; ((uintptr_t)(qq__threadid) < (threads).length()) && ((threadid = (threads).v[(intptr_t)qq__threadid]) || 1); qq__threadid = (pid_t *)(((intptr_t)qq__threadid) + 1))
                                                                                                                                                                                           ^  ~
../../../../mgmt/api/CoreAPI.cc:370:188: note: use '|' for a bitwise operation
  if ((threads).n) for (pid_t *qq__threadid = (pid_t *)0, threadid = (threads).v[0]; ((uintptr_t)(qq__threadid) < (threads).length()) && ((threadid = (threads).v[(intptr_t)qq__threadid]) || 1); qq__threadid = (pid_t *)(((intptr_t)qq__threadid) + 1))
                                                                                                                                                                                           ^~
                                                                                                                                                                                           |
1 error generated.

Issue Links

• is duplicated by: TS-3208 clang warnings on || 1