[TS-3208] clang warnings on || 1

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Component/s: Management API
• Assignee: Alan M. Carroll
• Reporter: Leif Hedstrom
• Created: 22/Nov/14 01:51
• Updated: 04/Feb/16 19:02
• Resolved: 17/Dec/15 02:43

Description

CoreAPI.cc:368:187: warning: use of logical '||' with constant operand [-Wconstant-logical-operand]
  if ((threads).n) for (pid_t *qq__threadid = (pid_t*)0, threadid = (threads).v[0]; ((uintptr_t)(qq__threadid) < (threads).length()) && ((threadid = (threads).v[(intptr_t)qq__threadid]) || 1); qq__threadid = (pid_t*)(((intptr_t)qq__threadid) + 1)) {
                                                                                                                                                                                          ^  ~
CoreAPI.cc:368:187: note: use '|' for a bitwise operation
  if ((threads).n) for (pid_t *qq__threadid = (pid_t*)0, threadid = (threads).v[0]; ((uintptr_t)(qq__threadid) < (threads).length()) && ((threadid = (threads).v[(intptr_t)qq__threadid]) || 1); qq__threadid = (pid_t*)(((intptr_t)qq__threadid) + 1)) {
                                                                                                                                                                                          ^~
                                                                                                                                                                                          

Issue Links

• duplicates: TS-3935 Compile errors (warnings) with modern clang