[TS-3795] Invalid assertion in handle_server_connection_not_open

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 6.1.0
• Component/s: Core
• Assignee: Unassigned
• Reporter: Alan M. Carroll
• Created: 23/Jul/15 21:05
• Updated: 03/Aug/15 15:05
• Resolved: 03/Aug/15 15:05

Description

In HttpTransact::handle_server_connection_not_open there is an early assert

ink_assert(s->current.server->had_connect_fail());

However, in HttpTransact::handle_response_from_server the cases of a parse error, connection closed, or a bad response all call this method and in none of these cases was there a connection failure. This causes an assertion which, to me, seems unreasonable.

Issue Links

• duplicates: TS-3776 traffic_server failed assert `s->current.server->had_connect_fail()`
• is broken by: TS-3440 Connect_retries re-connects even if request made it to origin