[TS-3440] Connect_retries re-connects even if request made it to origin

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Fix Version/s: 6.0.0
• Assignee: Thomas Jackson
• Reporter: Thomas Jackson
• Created: 13/Mar/15 02:35
• Updated: 07/Jun/16 16:27
• Resolved: 07/Apr/16 02:04

Description

While trying to workaround TS-3439 I decided to test out the connect retries option. During testing I found a case where it should not retry where it is.

The scenario is as follows:

• ATS makes a connection to an origin
• the origin acks the entire request
• the origin starts to send back a response (lets say first line of the header)
• the origin sends an RST

In this scenario ATS will re-connect to the origin, which is bad since we have already sent the request (and we aren't sure if the URL is re-entrant).

Test case: https://github.com/jacksontj/trafficserver/commit/28059ccb93f9fb173792aeebf90062882dfdf9d5#diff-06f9ddbe6cc45d76ebb2cb21479dc805R182

Issue Links

• breaks: TS-3776 traffic_server failed assert `s->current.server->had_connect_fail()`
• breaks: TS-3795 Invalid assertion in handle_server_connection_not_open
• relates to: TS-4328 Connect_retries re-connects even if request made it to origin (TS-3440 repeat)