Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2574

Don't gitignore package-lock.json

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Trivial
    • Resolution: Done
    • Affects Version/s: 3.4.11
    • Fix Version/s: 3.5.0, 3.3.11, 3.4.11
    • Component/s: gremlint, javascript
    • Labels:
      None

      Description

      Creating this task as a follow-up to https://issues.apache.org/jira/browse/TINKERPOP-2572.

      To make sure the result of running npm install is deterministic, package-lock.json should be committed along with package.json instead of being gitignored. This will prevent older package-lock.json files that may exist locally from earlier installs from being used to determine what versions to install when running npm install.

      I'm not 100% sure I understand how the Affects Version and Fix Version fields should be set when creating the Jira ticket. Feedback appreciated.

        Attachments

          Activity

            People

            • Assignee:
              oyvindsabo Øyvind Sæbø
              Reporter:
              oyvindsabo Øyvind Sæbø
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified