Details
-
Improvement
-
Status: Closed
-
Trivial
-
Resolution: Done
-
3.4.11
-
None
Description
Creating this task as a follow-up to https://issues.apache.org/jira/browse/TINKERPOP-2572.
To make sure the result of running npm install is deterministic, package-lock.json should be committed along with package.json instead of being gitignored. This will prevent older package-lock.json files that may exist locally from earlier installs from being used to determine what versions to install when running npm install.
I'm not 100% sure I understand how the Affects Version and Fix Version fields should be set when creating the Jira ticket. Feedback appreciated.
we usually just set the "affects version" to the oldest version where we see the problem (so typically just one value there and in this case would be 3.4.11 - sorry, shouldn't have said 3.3.11 originally). we usually set the fix version when we close the issue and set it to all the versions within which it was fixed. for this particular situation, you have a pretty simple administrative change. i think you would be within rights to have not bothered to create a JIRA and just did a commit/push as CTR - see the last bullet point in this section: https://tinkerpop.apache.org/docs/current/dev/developer/#rtc
So, you would checkout 3.4-dev, make your change, commit locally with "CTR" in the comment (like i did earlier today here as an example). then, basically:
then push in reverse order: