Uploaded image for project: 'TinkerPop'
  1. TinkerPop
  2. TINKERPOP-2526

Gremlin Console performance with incomplete multi-line scripts

Details

    Description

      Gremlin Console is impossibly slow for incomplete multi-line use cases which is common for Gremlin. The issue appears to be related to the Groovy 3.x upgrade. More details can be found here: GROOVY-9785

      Note that this is a major blocker for 3.5.0 release as we can't generate documentation right now (takes well over 24 hours to generate and most times it simply crashes).

      Attachments

        Issue Links

          Activity

            Reduced priority as the working expectation at this point is to simply revert to Groovy 2.x. 3.5.0 will not ship Groovy 3.0.

            spmallette Stephen Mallette added a comment - Reduced priority as the working expectation at this point is to simply revert to Groovy 2.x. 3.5.0 will not ship Groovy 3.0.

            Someone else brought up performance issues with Groovy 3/4 on their dev list. Decided to try to bring some fresh attention to our problems with that:

            https://lists.apache.org/thread.html/r212ea2787ecb345ee24bcf5a0374e9a10f0bbe86dca4338fb30dfade%40%3Cdev.groovy.apache.org%3E

            Perhaps the problems are unrelated. Not much follow-up to the post in these first 24 hours, though there do seem to be some configurations to potentially try:

            https://github.com/apache/groovy/blob/master/src/spec/doc/performance-guide.adoc

            I will look into those to see if they help, but I believe I've tried some of them already.

            spmallette Stephen Mallette added a comment - Someone else brought up performance issues with Groovy 3/4 on their dev list. Decided to try to bring some fresh attention to our problems with that: https://lists.apache.org/thread.html/r212ea2787ecb345ee24bcf5a0374e9a10f0bbe86dca4338fb30dfade%40%3Cdev.groovy.apache.org%3E Perhaps the problems are unrelated. Not much follow-up to the post in these first 24 hours, though there do seem to be some configurations to potentially try: https://github.com/apache/groovy/blob/master/src/spec/doc/performance-guide.adoc I will look into those to see if they help, but I believe I've tried some of them already.
            githubbot ASF GitHub Bot added a comment -

            kenhuuu opened a new pull request, #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983

            Adding imports by providing the CompilerConfiguration with an ImportCustomizer greatly improves performance because the imports won't be resolved again for each complete line in a script.

            githubbot ASF GitHub Bot added a comment - kenhuuu opened a new pull request, #1983: URL: https://github.com/apache/tinkerpop/pull/1983 Adding imports by providing the CompilerConfiguration with an ImportCustomizer greatly improves performance because the imports won't be resolved again for each complete line in a script.
            githubbot ASF GitHub Bot added a comment -

            vkagamlyk commented on PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1447583559

            VOTE +1

            githubbot ASF GitHub Bot added a comment - vkagamlyk commented on PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1447583559 VOTE +1
            githubbot ASF GitHub Bot added a comment -

            Cole-Greer commented on PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1448757832

            Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included?

            githubbot ASF GitHub Bot added a comment - Cole-Greer commented on PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1448757832 Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included?
            githubbot ASF GitHub Bot added a comment -

            spmallette commented on PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450678996

            wow - hard to believe this was the fix all this time. incredible job getting to the bottom of this and working with the Groovy Community to help solve it. this fix unlocks a lot of blockages. hero! 🏅

            needs a CHANGELOG entry, but other than that:

            VOTE +1

            githubbot ASF GitHub Bot added a comment - spmallette commented on PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450678996 wow - hard to believe this was the fix all this time. incredible job getting to the bottom of this and working with the Groovy Community to help solve it. this fix unlocks a lot of blockages. hero! 🏅 needs a CHANGELOG entry, but other than that: VOTE +1
            githubbot ASF GitHub Bot added a comment -

            kenhuuu commented on PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450895996

            > Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included?

            With these changes and Groovy 2.5.17 (a version we noticed a slowdown with), the 3.5.5 documentation processing took roughly 25 min. The 3.5.5 release code takes about 90m to do the same documentation processing.

            githubbot ASF GitHub Bot added a comment - kenhuuu commented on PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1450895996 > Previously building the docs was impossibly slow on any groovy version beyond 2.5.15. What is the doc building performance on newer versions of groovy with these changes included? With these changes and Groovy 2.5.17 (a version we noticed a slowdown with), the 3.5.5 documentation processing took roughly 25 min. The 3.5.5 release code takes about 90m to do the same documentation processing.
            githubbot ASF GitHub Bot added a comment -

            kenhuuu commented on PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1452625213

            VOTE + 1

            githubbot ASF GitHub Bot added a comment - kenhuuu commented on PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983#issuecomment-1452625213 VOTE + 1
            githubbot ASF GitHub Bot added a comment -

            kenhuuu merged PR #1983:
            URL: https://github.com/apache/tinkerpop/pull/1983

            githubbot ASF GitHub Bot added a comment - kenhuuu merged PR #1983: URL: https://github.com/apache/tinkerpop/pull/1983

            People

              Unassigned Unassigned
              spmallette Stephen Mallette
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: