[GROOVY-9785] Performance degradation of groovysh for long scripts

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Information Provided
• Affects Version/s: 3.0.6
• Component/s: Groovysh, parser-antlr4
• Assignee: Eric Milles
• Reporter: Stephen Mallette
• Created: 20/Oct/20 10:48
• Updated: 22/Dec/23 11:38
• Resolved: 20/Mar/23 14:46

Description

This issue was initially raised on the groovy-users mailing list (here). The general issue is that long scripts pasted to groovysh in 3.x are parsed/read much more slowly than prior 2.x versions. From the mailing list:

groovy:000> start = System.currentTimeMillis()
===> 1603105239050
groovy:000> 1 + 10 +
groovy:001> 1 + 10 +
groovy:002> 1 + 10 +
groovy:003> 1 + 10 +
groovy:004> 1 + 10 +
groovy:005> 1 + 10 +
groovy:006> 1 + 10 +
...
groovy:495> 1 + 10 +
groovy:496> 1 + 10 +
groovy:497> 1 + 10
===> 5478
groovy:000> System.currentTimeMillis() - start
===> 1193

and on 3.0.6 I got:

groovy:000> start = System.currentTimeMillis()
===> 1603105244825
groovy:000> 1 + 10 +
groovy:001> 1 + 10 +
groovy:002> 1 + 10 +
groovy:003> 1 + 10 +
groovy:004> 1 + 10 +
groovy:005> 1 + 10 +
groovy:006> 1 + 10 +
...
groovy:495> 1 + 10 +
groovy:496> 1 + 10 +
groovy:497> 1 + 10
===> 5478
groovy:000> System.currentTimeMillis() - start
===> 31876

Note that JFRs are attached - perhaps they will shed some light on what is happening to someone familiar with the code.

Issue Links

• blocks: TINKERPOP-2526 Gremlin Console performance with incomplete multi-line scripts
• is related to: GROOVY-10454 Performance issue with "Parrot" parser in Groovy 3.x
• is related to: GROOVY-8279 Adapt groovysh to compile using the new parser Parrot