Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-2368

Clean up SentimentParser dependencies

    Details

    • Type: Improvement
    • Status: Reopened
    • Priority: Blocker
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Is there any way to avoid reliance on edu.usc.ir's sentiment-analysis-parser? I ask because:

      [WARNING] sentiment-analysis-parser-0.1.jar, tika-parsers-1.15-SNAPSHOT.jar define 1 overlapping classes: 
      [WARNING]   - org.apache.tika.parser.sentiment.analysis.SentimentParser
      [WARNING] tika-core-1.15-SNAPSHOT.jar, tika-translate-1.15-SNAPSHOT.jar define 4 overlapping classes: 
      [WARNING]   - org.apache.tika.language.translate.DefaultTranslator$1
      [WARNING]   - org.apache.tika.language.translate.EmptyTranslator
      [WARNING]   - org.apache.tika.language.translate.DefaultTranslator
      [WARNING]   - org.apache.tika.language.translate.Translator
      

      We should be ok keeping things as they are and excluding SentimentParser and tika-translate, but can we easily move the code that's still in edu.usc.ir's package into Tika?

        Issue Links

          Activity

          Hide
          chrismattmann Chris A. Mattmann added a comment -

          yeah we'll definitely work on this probably will happen post 1.15. I need to clean the whole thing up, and get the OpenNLP stuff upstream into Apache OpenNLP (including the age detection work we did too). The USC part can be thin like our other code.

          Show
          chrismattmann Chris A. Mattmann added a comment - yeah we'll definitely work on this probably will happen post 1.15. I need to clean the whole thing up, and get the OpenNLP stuff upstream into Apache OpenNLP (including the age detection work we did too). The USC part can be thin like our other code.
          Hide
          tallison@mitre.org Tim Allison added a comment -

          I added tika-translate to the exclusion list. We'll still get an overlapping warning on SentimentParser, but this should be good enough for 1.15. I've removed "blocker" status.

          Show
          tallison@mitre.org Tim Allison added a comment - I added tika-translate to the exclusion list. We'll still get an overlapping warning on SentimentParser, but this should be good enough for 1.15. I've removed "blocker" status.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Tika-trunk #1270 (See https://builds.apache.org/job/Tika-trunk/1270/)
          TIKA-2368: Clean up dependencies of SentimentParser. At a bare minimum (tallison: https://github.com/apache/tika/commit/993382c1ea91ceb00bb4d6f817e03d2c7d5253a4)

          • (edit) tika-parsers/pom.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Tika-trunk #1270 (See https://builds.apache.org/job/Tika-trunk/1270/ ) TIKA-2368 : Clean up dependencies of SentimentParser. At a bare minimum (tallison: https://github.com/apache/tika/commit/993382c1ea91ceb00bb4d6f817e03d2c7d5253a4 ) (edit) tika-parsers/pom.xml
          Hide
          chrismattmann Chris A. Mattmann added a comment -

          +1

          Show
          chrismattmann Chris A. Mattmann added a comment - +1
          Hide
          chrismattmann Chris A. Mattmann added a comment -

          thanks Tim!

          Show
          chrismattmann Chris A. Mattmann added a comment - thanks Tim!
          Hide
          tmortagne Thomas Mortagne added a comment -

          The source of the SentimentParser classes in sentiment-analysis-parser and tika-parsers are very different so I'm not sure how this can be OK when you can end up with one or the other pretty much randomly.

          Which of those classes is the right one and is there any plan to actually fix this issue ?

          Show
          tmortagne Thomas Mortagne added a comment - The source of the SentimentParser classes in sentiment-analysis-parser and tika-parsers are very different so I'm not sure how this can be OK when you can end up with one or the other pretty much randomly. Which of those classes is the right one and is there any plan to actually fix this issue ?
          Hide
          tallison@mitre.org Tim Allison added a comment -

          Thomas Mortagne, thank you comparing the classes. I had assumed that they were the same. I agree that we need to fix this.

          Show
          tallison@mitre.org Tim Allison added a comment - Thomas Mortagne , thank you comparing the classes. I had assumed that they were the same. I agree that we need to fix this.
          Hide
          tallison@mitre.org Tim Allison added a comment -

          Chris A. Mattmann, how much work will this take?

          Show
          tallison@mitre.org Tim Allison added a comment - Chris A. Mattmann , how much work will this take?
          Hide
          chrismattmann Chris A. Mattmann added a comment -

          hey Tim Allison we're working on this right now, and hope to have it fixed in time for 1.16. You can see the work going on here: http://github.com/USCDataScience/SentimentAnalysisParser/pulls

          Show
          chrismattmann Chris A. Mattmann added a comment - hey Tim Allison we're working on this right now, and hope to have it fixed in time for 1.16. You can see the work going on here: http://github.com/USCDataScience/SentimentAnalysisParser/pulls
          Hide
          tallison@mitre.org Tim Allison added a comment -

          W00t! 1.15.1?

          Show
          tallison@mitre.org Tim Allison added a comment - W00t! 1.15.1?
          Hide
          tallison@mitre.org Tim Allison added a comment -

          For now, I'll rename Tika's SentimentParser to SentimentAnalysisParser to avoid our current conflicts unless there are objections.

          Show
          tallison@mitre.org Tim Allison added a comment - For now, I'll rename Tika's SentimentParser to SentimentAnalysisParser to avoid our current conflicts unless there are objections.
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Tika-trunk #1301 (See https://builds.apache.org/job/Tika-trunk/1301/)
          TIKA-2368 – rename SentimentParser to avoid conflict with dependency (tallison: https://github.com/apache/tika/commit/b409ff65abdb4d364db66be39be35513abf89b54)

          • (edit) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp-cat.xml
          • (add) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParser.java
          • (edit) CHANGES.txt
          • (edit) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp.xml
          • (delete) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentParserTest.java
          • (delete) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentParser.java
          • (add) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParserTest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Tika-trunk #1301 (See https://builds.apache.org/job/Tika-trunk/1301/ ) TIKA-2368 – rename SentimentParser to avoid conflict with dependency (tallison: https://github.com/apache/tika/commit/b409ff65abdb4d364db66be39be35513abf89b54 ) (edit) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp-cat.xml (add) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParser.java (edit) CHANGES.txt (edit) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp.xml (delete) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentParserTest.java (delete) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentParser.java (add) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParserTest.java
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Tika-trunk #1305 (See https://builds.apache.org/job/Tika-trunk/1305/)
          TIKA-2368 – move to different package to avoid split package warning (tallison: https://github.com/apache/tika/commit/bfedea8fd871d20db93af6b493d82a4b10ea4171)

          • (add) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/tika-config-sentiment-opennlp-cat.xml
          • (delete) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParser.java
          • (add) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/tika-config-sentiment-opennlp.xml
          • (delete) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp.xml
          • (add) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/SentimentAnalysisParser.java
          • (add) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/SentimentAnalysisParserTest.java
          • (delete) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp-cat.xml
          • (delete) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParserTest.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Tika-trunk #1305 (See https://builds.apache.org/job/Tika-trunk/1305/ ) TIKA-2368 – move to different package to avoid split package warning (tallison: https://github.com/apache/tika/commit/bfedea8fd871d20db93af6b493d82a4b10ea4171 ) (add) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/tika-config-sentiment-opennlp-cat.xml (delete) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParser.java (add) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/tika-config-sentiment-opennlp.xml (delete) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp.xml (add) tika-parsers/src/main/java/org/apache/tika/parser/sentiment/SentimentAnalysisParser.java (add) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/SentimentAnalysisParserTest.java (delete) tika-parsers/src/test/resources/org/apache/tika/parser/sentiment/analysis/tika-config-sentiment-opennlp-cat.xml (delete) tika-parsers/src/test/java/org/apache/tika/parser/sentiment/analysis/SentimentAnalysisParserTest.java

            People

            • Assignee:
              Unassigned
              Reporter:
              tallison@mitre.org Tim Allison
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:

                Development