Uploaded image for project: 'Tika'
  1. Tika
  2. TIKA-1870

Relocating RichTextContentHandler into tika-core from tika-server

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.13
    • Component/s: core, server
    • Labels:
    • Flags:
      Patch

      Description

      linked to TIKA-1868, different solution by refactoring class into tika-core so don't need to depend upon tika-server and changing other classes used to custom ones or other alternatives.

        Issue Links

          Activity

          Hide
          gagravarr Nick Burch added a comment -

          Currently the class lacks javadocs to explain what it does, and seems to lack unit tests. Any chance you could knock up a patch to fix those two, then we can move it over? (Potentially you'd need to put the unit test in the Tika Parsers test package, to get access to the test documents, unless you just in-lined a small snippet of HTML to show the translation)

          Show
          gagravarr Nick Burch added a comment - Currently the class lacks javadocs to explain what it does, and seems to lack unit tests. Any chance you could knock up a patch to fix those two, then we can move it over? (Potentially you'd need to put the unit test in the Tika Parsers test package, to get access to the test documents, unless you just in-lined a small snippet of HTML to show the translation)
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user nhojpatrick opened a pull request:

          https://github.com/apache/tika/pull/77

          TIKA-1870 refactor RichTextContentHandler into tika-core from tika-se…

          …rver so users if needing it don't need to depend upon tika-server

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/nhojpatrick/tika bugfix/TIKA-1870

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/tika/pull/77.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #77


          commit 0bd05cec54c581c971d90380304aaa23c9543296
          Author: John Patrick <nhoj.patrick@gmail.com>
          Date: 2016-02-24T14:50:38Z

          TIKA-1870 refactor RichTextContentHandler into tika-core from tika-server so users if needing it don't need to depend upon tika-server


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user nhojpatrick opened a pull request: https://github.com/apache/tika/pull/77 TIKA-1870 refactor RichTextContentHandler into tika-core from tika-se… …rver so users if needing it don't need to depend upon tika-server You can merge this pull request into a Git repository by running: $ git pull https://github.com/nhojpatrick/tika bugfix/ TIKA-1870 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tika/pull/77.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #77 commit 0bd05cec54c581c971d90380304aaa23c9543296 Author: John Patrick <nhoj.patrick@gmail.com> Date: 2016-02-24T14:50:38Z TIKA-1870 refactor RichTextContentHandler into tika-core from tika-server so users if needing it don't need to depend upon tika-server
          Hide
          nhoj.patrick John Patrick added a comment -

          Added JavaDoc and Unit Test, although I'm assuming I've documented and tested it correctly.

          Show
          nhoj.patrick John Patrick added a comment - Added JavaDoc and Unit Test, although I'm assuming I've documented and tested it correctly.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/tika/pull/77

          Show
          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/tika/pull/77
          Hide
          gagravarr Nick Burch added a comment -

          Thanks for preparing patches for all this work. Merged and pushed!

          Show
          gagravarr Nick Burch added a comment - Thanks for preparing patches for all this work. Merged and pushed!
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in tika-trunk-jdk1.7 #915 (See https://builds.apache.org/job/tika-trunk-jdk1.7/915/)
          TIKA-1870 refactor RichTextContentHandler into tika-core from (nhoj.patrick: rev 0bd05cec54c581c971d90380304aaa23c9543296)

          • tika-server/src/main/java/org/apache/tika/server/resource/UnpackerResource.java
          • tika-core/src/main/java/org/apache/tika/sax/RichTextContentHandler.java
          • tika-server/src/main/java/org/apache/tika/server/resource/TikaResource.java
          • tika-server/src/main/java/org/apache/tika/server/RichTextContentHandler.java
            TIKA-1870 JavaDoc and Test coverage for RichTextContentHandler that (nhoj.patrick: rev 3b7922db1a2e72181e1a00168d2aee33bfe1d4a3)
          • tika-core/src/test/java/org/apache/tika/sax/RichTextContentHandlerTest.java
          • tika-core/src/main/java/org/apache/tika/sax/RichTextContentHandler.java
            TIKA-1870 Move RichTextContentHandler from Server to Core, contributed (nick: rev ed762b702875c843d0322b8ba6d05385ca91875d)
          • CHANGES.txt
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in tika-trunk-jdk1.7 #915 (See https://builds.apache.org/job/tika-trunk-jdk1.7/915/ ) TIKA-1870 refactor RichTextContentHandler into tika-core from (nhoj.patrick: rev 0bd05cec54c581c971d90380304aaa23c9543296) tika-server/src/main/java/org/apache/tika/server/resource/UnpackerResource.java tika-core/src/main/java/org/apache/tika/sax/RichTextContentHandler.java tika-server/src/main/java/org/apache/tika/server/resource/TikaResource.java tika-server/src/main/java/org/apache/tika/server/RichTextContentHandler.java TIKA-1870 JavaDoc and Test coverage for RichTextContentHandler that (nhoj.patrick: rev 3b7922db1a2e72181e1a00168d2aee33bfe1d4a3) tika-core/src/test/java/org/apache/tika/sax/RichTextContentHandlerTest.java tika-core/src/main/java/org/apache/tika/sax/RichTextContentHandler.java TIKA-1870 Move RichTextContentHandler from Server to Core, contributed (nick: rev ed762b702875c843d0322b8ba6d05385ca91875d) CHANGES.txt

            People

            • Assignee:
              Unassigned
              Reporter:
              nhoj.patrick John Patrick
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development