Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-811

http_client_transport.rb: allow custom http headers

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 0.4
    • 0.4
    • Ruby - Library
    • None
    • Patch Available

    Description

      The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            tkamenick Tony Kamenick
            tkamenick Tony Kamenick
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment