Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-811

http_client_transport.rb: allow custom http headers

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.4
    • Fix Version/s: 0.4
    • Component/s: Ruby - Library
    • Labels:
      None
    • Patch Info:
      Patch Available

      Description

      The http headers in http_client_transport.rb were defined locally in flush, so the user could not easily specify custom headers. I made headers an instance variable and created an add_headers() method that accepts a hash of headers to send to the server. I included a test that fails before the patch and succeeds afterward. My editor also moved some trailing white space that was hanging out.

        Attachments

        1. custom_http_headers.patch
          3 kB
          Tony Kamenick

          Activity

            People

            • Assignee:
              tkamenick Tony Kamenick
              Reporter:
              tkamenick Tony Kamenick
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: