[THRIFT-541] Cocoa code generator doesn't put keywords before all arguments.

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 0.9
• Component/s: Cocoa - Compiler
• Patch Info: Patch Available
• Assignee: Andrew McGeachie
• Reporter: Matt Ronge
• Created: 12/Jul/09 03:42
• Updated: 16/May/12 04:21
• Resolved: 16/May/12 03:50

Description

The compiler doesn't put keywords in front of all args. Per Cocoa coding conventions (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH) all args should have a keyword.

Currently this would be generated

• (int32_t) calculate: (int32_t) logid : (Work *) w;

But this is better

• (int32_t) calculate: (int32_t) logid w: (Work *) w;

Attached is a very small patch that uses the name of the arg variable as the keyword.