Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-541

Cocoa code generator doesn't put keywords before all arguments.

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • 0.9
    • Cocoa - Compiler
    • None
    • Patch Available

    Description

      The compiler doesn't put keywords in front of all args. Per Cocoa coding conventions (http://developer.apple.com/documentation/Cocoa/Conceptual/CodingGuidelines/Articles/NamingMethods.html#//apple_ref/doc/uid/20001282-1001751-BCIJHEDH) all args should have a keyword.

      Currently this would be generated

      • (int32_t) calculate: (int32_t) logid : (Work *) w;

      But this is better

      • (int32_t) calculate: (int32_t) logid w: (Work *) w;

      Attached is a very small patch that uses the name of the arg variable as the keyword.

      Attachments

        1. arg_name_fix.patch
          0.8 kB
          Matt Ronge

        Activity

          People

            geechorama Andrew McGeachie
            mronge Matt Ronge
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: