[THRIFT-4938] Issues with version.h treatment

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.13.0
• Fix Version/s: 0.14.0
• Component/s: Compiler (General)

Environment

windows 7, thrift-master,visual studio 2015

• Assignee: Jens Geyer
• Reporter: pengzhouhu
• Created: 23/Aug/19 06:40
• Updated: 11/Feb/21 22:27
• Resolved: 20/Oct/19 14:25

Description

resloved this compatibility display version error because PACKAGE_VERSION value will not be initialization when we built compiler by visual studio 2015.
Maybe few people used to handle project on windows by this IDE, and i think there is still some jobs we need to take to support except that. Need your advice whether i should do these things.

Github PR link:https://github.com/apache/thrift/pull/1853

Thanks.
zhouhu.

Issue Links

• links to: GitHub Pull Request #1853
• links to: GitHub Pull Request #1858
• links to: GitHub Pull Request #1902