Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4938

Issues with version.h treatment

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.13.0
    • 0.14.0
    • Compiler (General)
    • None
    • windows 7, thrift-master,visual studio 2015

    Description

      resloved this compatibility display version error because PACKAGE_VERSION value will not be initialization when we built compiler by visual studio 2015.
      Maybe few people used to handle project on windows by this IDE, and i think there is still some jobs we need to take to support except that. Need your advice whether i should do these things.

      Github PR link:https://github.com/apache/thrift/pull/1853

      Thanks.
      zhouhu.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            pengzhouhu pengzhouhu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 50m
                50m

                Slack

                  Issue deployment