[THRIFT-4907] strong named assemblies wanted

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: C# - Library, netcore - Library, netstd - Library
• Assignee: Jens Geyer
• Reporter: Benjamin Kraemer
• Created: 10/Jul/19 09:35
• Updated: 16/Oct/19 22:27
• Resolved: 25/Aug/19 12:07

Description

In THRIFT-2947, a strong name should have been added to https://www.nuget.org/packages/ApacheThrift/0.12.0.1

Looking at the DLL, it's not signed at all. The assembly name is still `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and therefore missing the `PublicKeyToken` part.

Issue Links

• is broken by: THRIFT-2947 Using Apache code signing service to sign the Thrift NuGet project
• links to: GitHub Pull Request #1854