Uploaded image for project: 'Thrift'
  1. Thrift
  2. THRIFT-4907

strong named assemblies wanted

VotersWatch issueWatchersLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      In THRIFT-2947, a strong name should have been added to https://www.nuget.org/packages/ApacheThrift/0.12.0.1

      Looking at the DLL, it's not signed at all. The assembly name is still `Thrift, Version=0.12.0.0, Culture=neutral, PublicKeyToken=null` and therefore missing the `PublicKeyToken` part.

      Attachments

        Issue Links

        is broken by

        Improvement - An improvement or enhancement to an existing feature or task. THRIFT-2947 Using Apache code signing service to sign the Thrift NuGet project

        • Major - Major loss of function.
        • Resolved
        links to

        Web Link GitHub Pull Request #1854

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jensg Jens Geyer
            Falco20019 Benjamin Kraemer
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 20m
                20m

                Slack

                  Issue deployment