[THRIFT-4547] Finish the conversion to native swift (LANGUAGES.md, cross test)

• Type: Story
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.18.0
• Component/s: Swift - Library
• Assignee: Kino
• Reporter: James E. King III
• Created: 08/Apr/18 11:10
• Updated: 13/Feb/23 21:10
• Resolved: 09/Oct/22 21:41

Description

Support for Swift-3 was added in THRIFT-3773, however this work needs to be completed.

Are there breaking changes?

No/Yes? The compiler is written to allow for the Old Cocoa/Swift with a compiler flag, so anyone still using swift 1 or 2 should still be able to use the Cocoa style generator but will have to use a compiler flag

Are they documented?

I don't believe thats documented anywhere

Is it already running in the cross test or is that future work?

No tests written for this, that is future work

Can this be exercised in the Travis CI build environment? (make check, make cross?)

Should be exercisable in Travis though no tests currently

Can I add swift support to Ubuntu Xenial and Artful?

I'm not sure where the Swift compiler support for Xenial and Artful currently is, but should be available.

What minimum and maximum versions are known supported?

Given backwards compatibility with Cocoa/Swift generator this should work with all Swift versions v1 through v4 (for Swift 1 and 2, the Cocoa library which is Obj-C is required along with the cocoa flag when generating code, for Swift 3+ the dedicated Swift library is required)

Has the LANGUAGES.md file been updated?

LANGUAGES.md has not been updated

Has the build/docker/README.md file been updated?

build/docker/README.md have not been updated

Is this supposed to replace the cocoa implementation? Should that be removed?

The cocoa implementation is separate from this implementation. The Cocoa compiler/libraries exist for Obj-C, and Swift 1 & 2, whereas Swift 3+ operate independently without Cocoa (as Swift 3 and up can run on Linux without Obj-C runtime/libraries). That being said the old Swift/Cocoa compiler is "gone/removed" and there is "only 1 Swift compiler" given the old Swift/Cocoa compiler is integrated in this as a compiler flag

Issue Links

• is blocked by: THRIFT-5629 Add UUID support for Swift
• is blocked by: THRIFT-5630 Swift TSocketServer not working on Linux
• is caused by: THRIFT-3773 Swift Library
• is related to: THRIFT-4902 Swift compatibility with Swift 4.2, 5.0 and 5.1
• links to: GitHub Pull Request #1660
• links to: GitHub Pull Request #2048